LRC-160: cleanup build process #20
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Hi @dwdougherty , removing this at this stage would mean that we would skip those file also as part of the execution of the migrate.py script. So I would avoid merging this in until the final migration is done. Regards, |
dmaier-redislabs
changed the title
Collaborator
Author
|
Understood. I've added the "do not merge yet" label. |
dwdougherty
changed the title
dmaier-redislabs
approved these changes
Apr 10, 2024
Contributor
dmaier-redislabs
left a comment
dmaier-redislabs
left a comment
There was a problem hiding this comment.
Should be fine because we changed to a mono repo. @dwdougherty What does _process_docs do?
Collaborator
Author
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The build process was doing a lot of useless work and making unnecessary changes to lots of Markdown files. This PR fixes that.